improvement: assert description in Crowdfund.finalize() #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
approved these changes
Aug 9, 2022
Codecov Report
@@ Coverage Diff @@
## master #3058 +/- ##
==========================================
- Coverage 88.34% 88.30% -0.05%
==========================================
Files 97 97
Lines 10963 10968 +5
Branches 2590 2593 +3
==========================================
Hits 9685 9685
- Misses 830 834 +4
- Partials 448 449 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Changed "the goal has been reached" to "the goal has not been reached" in assert description as in case of an assertion failed that would mean that goal is not reached and this could be misleading.
How I did it
It was fast and easy, just a typo
How to verify it
Follow the links:
https://raw.githubusercontent.com/vyperlang/vyper/master/examples/crowdfund.vy
https://raw.githubusercontent.com/nfwsncked/vyper/master/examples/crowdfund.vy
Commit message
improvement: assert description in Crowdfund.finalize()
Description for the changelog
Fixed a typo in Crowdfund.finalize() assertion description
Cute Animal Picture