Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty nested dynamic arrays #3061

Merged
merged 10 commits into from
Aug 15, 2022

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Aug 11, 2022

What I did

Fix #3048.

Check for empty dynamic arrays recursively.

How I did it

Add a helper function _is_empty_list to recursively determine if a literal list is empty.

How to verify it

See tests.

Commit message

fix: allow variable length empty dynamic arrays

Description for the changelog

Allow variable length empty dynamic arrays

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #3061 (96d7b38) into master (c71b023) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 96d7b38 differs from pull request most recent head 3b54103. Consider uploading reports for the commit 3b54103 to get more accurate results

@@            Coverage Diff             @@
##           master    #3061      +/-   ##
==========================================
+ Coverage   88.35%   88.36%   +0.01%     
==========================================
  Files          97       97              
  Lines       10968    10980      +12     
  Branches     2593     2597       +4     
==========================================
+ Hits         9691     9703      +12     
  Misses        827      827              
  Partials      450      450              
Impacted Files Coverage Δ
vyper/semantics/validation/utils.py 91.76% <100.00%> (+0.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper enabled auto-merge (squash) August 15, 2022 16:59
@charles-cooper charles-cooper merged commit 55f31f8 into vyperlang:master Aug 15, 2022
@tserg tserg deleted the fix/compare_type branch August 16, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'str' object has no attribute 'compare_type'
3 participants