chore: improve error message for non-checksummed address literal #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3065 +/- ##
=======================================
Coverage 88.35% 88.36%
=======================================
Files 97 97
Lines 10968 10974 +6
Branches 2593 2594 +1
=======================================
+ Hits 9691 9697 +6
Misses 827 827
Partials 450 450
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
charles-cooper
approved these changes
Aug 12, 2022
vyper/semantics/validation/utils.py
Outdated
Comment on lines
464
to
467
| len(expected_type) == 1 | ||
| and isinstance(expected_type[0], AddressDefinition) | ||
| and len(given_types) == 1 | ||
| and isinstance(given_types[0], Bytes20Definition) |
There was a problem hiding this comment.
nit -- because of preconditions earlier in this function, we know that both lists are nonzero. i think it's worth it to slightly generalize this check and remove the len() == 1 checks, because it's easier from a maintenance standpoint to constrain the check if it turns out to be wrong than to relax the constraint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
QOL improvement for #3062.
When declaring an address literal, the compiler throws an
InvalidTypeexception if it is not checksummed. This PR improves the error message by checking if the user meant the checksummed value.How I did it
Add an error message if expected type is address and the only possible type is bytes20.
How to verify it
NA
Commit message
Description for the changelog
Improve error message for non-checksummed address literal
Cute Animal Picture