fix: change mutability of example ERC721 interface #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following EIP-721, the function onERC721Received from the interface should be a state-modifying callback.
Codecov Report
@@ Coverage Diff @@
## master #3076 +/- ##
=======================================
Coverage 88.38% 88.38%
=======================================
Files 97 97
Lines 10999 10999
Branches 2599 2599
=======================================
Hits 9721 9721
Misses 828 828
Partials 450 450 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
charles-cooper
changed the title
charles-cooper
approved these changes
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arose from #3066. Following EIP-721, the function onERC721Received from the interface should be a state-modifying callback.
What I did
Replaced "view" mutability to "nonpayable" as the onERC721Received function should read from and write to the contract state.
How I did it
^^
How to verify it
Check the file changes.
Description for the changelog
Changed mutability of onERC721Received to nonpayable
Cute Animal Picture