-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate lark grammar #3082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took a quick look through, looks nice. will check more carefully later this weekend or on monday
Codecov Report
@@ Coverage Diff @@
## master #3082 +/- ##
==========================================
+ Coverage 88.34% 88.36% +0.02%
==========================================
Files 97 98 +1
Lines 11001 11020 +19
Branches 2602 2605 +3
==========================================
+ Hits 9719 9738 +19
Misses 832 832
Partials 450 450
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this PR needs this line to ensure the grammar is packaged with vyper: https://github.com/vyperlang/vyper/pull/2512/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R121
What I did
Partial implementation of #2512 to migrate Lark grammar to main directory, without exposing new AST output format.
How I did it
Replicate the earlier PR but skip exposing the AST as output.
How to verify it
See tests.
Commit message
Description for the changelog
Migrate Lark grammar to main directory
Cute Animal Picture