Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate lark grammar #3082

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Sep 3, 2022

What I did

Partial implementation of #2512 to migrate Lark grammar to main directory, without exposing new AST output format.

How I did it

Replicate the earlier PR but skip exposing the AST as output.

How to verify it

See tests.

Commit message

chore: migrate lark grammar

Migrate Lark grammar to main directory to
facilitate testing

Description for the changelog

Migrate Lark grammar to main directory

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a quick look through, looks nice. will check more carefully later this weekend or on monday

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Merging #3082 (9c8bce4) into master (0045b71) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3082      +/-   ##
==========================================
+ Coverage   88.34%   88.36%   +0.02%     
==========================================
  Files          97       98       +1     
  Lines       11001    11020      +19     
  Branches     2602     2605       +3     
==========================================
+ Hits         9719     9738      +19     
  Misses        832      832              
  Partials      450      450              
Impacted Files Coverage Δ
vyper/ast/grammar.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tserg tserg marked this pull request as ready for review September 3, 2022 17:09
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charles-cooper charles-cooper merged commit 915d430 into vyperlang:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants