fix: relax check for statically sized calldata #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a37bbbc introduced per-method calldatasize checks. however, for the case where calldata is statically sized (in the ABI sense), this check is too strict, since users might want to append extra bytes to the calldata and manipulate msg.data directly for some application-level reasons.
Codecov Report
@@ Coverage Diff @@
## master #3090 +/- ##
==========================================
- Coverage 88.34% 88.29% -0.06%
==========================================
Files 98 98
Lines 11021 11019 -2
Branches 2605 2604 -1
==========================================
- Hits 9737 9729 -8
- Misses 833 840 +7
+ Partials 451 450 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fubuloubu
approved these changes
Sep 12, 2022
|
made this contract to track when etherscan fixes their bug https://goerli.etherscan.io/address/0xa55c7877dff09f6ef55c583c9f43ff3d27dcc547#readContract after the fix, these calls should read |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a37bbbc (#2911) introduced per-method calldatasize checks. however, for the case where calldata is statically sized (in the ABI sense), this check is too strict, since users might want to append extra bytes to the calldata and manipulate msg.data directly for some application-level reasons.
What I did
How I did it
change "eq" to "ge"
How to verify it
see the tests
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture