feat: add lineno at the end of exception string pointing to file #3092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added lineno at the end of the part of the exception that mentions the contract throwing the error. This is similar to how python does exceptions, for example:
The added advantage of this is that it allows IDEs to navigate directly to the line that invokes the exception via
cmd+click
orctrl+click
(on, for example, VSCode).How I did it
Just add
node.lineno
in the exception string where the contract's dir is printed.How to verify it
you'll need to have a contract that borks. The exception will look something like:
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Adds line number at the end of exception string. The exceptions format conforms a bit better with how python exceptions are usually printed. An added use-case is that this allows IDEs to offer better code navigation, which improves devex.
Description for the changelog
Adds lineno at the end of exceptions string.
Cute Animal Picture
The most ferocious land animal ... or is it a good boi?