feat: optionally disable metadata in bytecode #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyper/ir/compile_ir.py
Outdated
| @@ -967,7 +967,7 @@ def adjust_pc_maps(pc_maps, ofst): | |||
| return ret | |||
|
|
|||
|
|
|||
| def assembly_to_evm(assembly, pc_ofst=0, insert_vyper_signature=False): | |||
| def assembly_to_evm(assembly, pc_ofst=0, insert_vyper_signature=False, disable_vyper_signature=False): | |||
There was a problem hiding this comment.
insert_vyper_signature and disable_vyper_signature both being arguments is a little weird. it should be the callers responsibility to decide what the value here should be
There was a problem hiding this comment.
correct, i agree, this was a short term resolution to avoid refactoring due to the recursive pattern L1011
|
thanks @charles-cooper renamed option to |
fubuloubu
approved these changes
Sep 26, 2022
emilianobonassi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Optionally disable metadata in bytecode
How I did it
Added the flag
--no-bytecode-metadatato the cli and pass the parameters in the respective componentsHow to verify it
Compile a contract with and without the flag. Bytecode produced will include or not the metadata (e.g. vyper signature) at the end
Commit message
feat: optionally disable metadata in bytecode
Description for the changelog
cli: optionally disable metadata in bytecode with
--no-bytecode-metadataCute Animal Picture