Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add bytecode metadata option to vyper-json #3117

Merged
merged 6 commits into from
Oct 9, 2022

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Oct 8, 2022

What I did

Fix #3110.

How I did it

Add "bytecodeMetadata" as a field under "settings" in JSON files.

How to verify it

Compile JSON file with and without the "bytecodeMetadata" field under "settings".

Commit message

fix: optionally disable metadata in bytecode for json input

Description for the changelog

Add bytecode matadata option for vyper-json.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Merging #3117 (6592825) into master (6020b8b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #3117    +/-   ##
========================================
  Coverage   88.49%   88.49%            
========================================
  Files          95       95            
  Lines       10758    10759     +1     
  Branches     2554     2265   -289     
========================================
+ Hits         9520     9521     +1     
  Misses        796      796            
  Partials      442      442            
Impacted Files Coverage Δ
vyper/cli/vyper_json.py 79.09% <100.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tserg tserg changed the title fix: add --no-bytecode-metadata option to vyper-json fix: add bytecode metadata option to vyper-json Oct 9, 2022
@tserg tserg marked this pull request as ready for review October 9, 2022 08:01
@charles-cooper charles-cooper merged commit f4deb13 into vyperlang:master Oct 9, 2022
@tserg tserg deleted the fix/json_cli branch October 10, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable metadata seemingly not available with JSON input
4 participants