add python 3.11 support #3129
add python 3.11 support #3129
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3129 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 84 84
Lines 10602 10602
Branches 2213 2213
=======================================
Hits 9431 9431
Misses 767 767
Partials 404 404 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
waiting on actions/runner-images#6459 |
|
I'm a bit eager to get the 3.11 support.. is everything good here? :) |
we are still waiting on gh actions runners to support |
if I read your guys' test yaml right, you need python 3.11 in this runner image. It's listed there now! |
charles-cooper
force-pushed
the
python-3.11
branch
from
d0531d5
to
5acbd42
Compare
|
now waiting on ethereum/web3.py#2699 |
setup.py
Outdated
| @@ -89,7 +89,7 @@ def _global_version(version): | |||
| keywords="ethereum evm smart contract language", | |||
| include_package_data=True, | |||
| packages=find_packages(exclude=("tests", "docs")), | |||
| python_requires=">=3.7,<3.11", | |||
| python_requires=">=3.8,<4", | |||
There was a problem hiding this comment.
Not sure when we can support 3.12, but probably not out of the gate
| python_requires=">=3.8,<4", | |
| python_requires=">=3.8,<3.12", |
There was a problem hiding this comment.
i think we should leave the upper bound unspecified so if/when the next python is released, people can try using vyper without us needing to explicitly open a PR and testing it
There was a problem hiding this comment.
Okay. I suppose the metadata shows that we don't explicitly support it yet
|
Seems like upgrading |
|
Will check! Note that since web3 is only required for our test suite- as of #3195 you should be able to install vyper with 3.11, it's just not tested/ officially supported. |
setup.py
Outdated
| @@ -16,7 +16,7 @@ | |||
| "pytest-rerunfailures>=10.2,<11", | |||
| "eth-tester[py-evm]>=0.6.0b6,<0.7", | |||
| "py-evm>=0.5.0a3,<0.6", | |||
| "web3==5.27.0", | |||
| "web3==5.31.3", | |||
There was a problem hiding this comment.
Can probably keep it like this just for occasionally testing updates for v6 until it's released
| "web3==5.31.3", | |
| "web3>=6.0.0b10,<7.0.0", |
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture