Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: loosen dependency on asttokens #3149

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

ozmium22
Copy link
Contributor

What I did

Loosen pin on asttokens to include a wider range

How I did it

Was

        "asttoken==2.0.5",

Now

        "asttokens>=2.0.5,<3"

How to verify it

Build and pass tests.

Commit message

Loosen dependency on asttokens to >=2.0.5,<3

Resolves: #3148

Description for the changelog

Change asttokens library requirement from ==2.0.5 to >=2.0.5,<3.

Cute Animal Picture

My new puppy:
Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper enabled auto-merge (squash) November 11, 2022 00:09
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Merging #3149 (2b40304) into master (886488f) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3149      +/-   ##
==========================================
- Coverage   88.49%   88.27%   -0.23%     
==========================================
  Files          95       95              
  Lines       10778    10778              
  Branches     2268     2268              
==========================================
- Hits         9538     9514      -24     
- Misses        797      820      +23     
- Partials      443      444       +1     
Impacted Files Coverage Δ
vyper/ast/annotation.py 94.57% <100.00%> (ø)
vyper/semantics/types/value/numeric.py 80.45% <0.00%> (-4.60%) ⬇️
vyper/builtin_functions/functions.py 89.28% <0.00%> (-1.37%) ⬇️
vyper/compiler/phases.py 90.17% <0.00%> (-0.90%) ⬇️
vyper/cli/vyper_json.py 78.74% <0.00%> (-0.35%) ⬇️
vyper/ir/compile_ir.py 93.55% <0.00%> (-0.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper
Copy link
Member

@ozmium22 looks like your change has introduced a mypy issue; could you please fix and repin the lower bound?

auto-merge was automatically disabled November 14, 2022 18:06

Head branch was pushed to by a user without write access

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 14, 2022

This pull request introduces 1 alert when merging d071eb6 into 886488f - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@ozmium22
Copy link
Contributor Author

ozmium22 commented Nov 14, 2022

@charles-cooper I added a cast to satisfy the tightened typing in asttokens > 2.0.5. I checked that this now passes the mypy check with all versions of asttokens from 2.0.5 to 2.1.0, so I think pinning to >=2.0.5,<3 should still be okay.

@charles-cooper charles-cooper enabled auto-merge (squash) November 14, 2022 18:40
@charles-cooper charles-cooper merged commit 46b6cfe into vyperlang:master Nov 14, 2022
@ozmium22 ozmium22 deleted the loosen-asttokens branch November 14, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asttokens dependency conflict with Ape framework (0.5.3+)
3 participants