Remove slice() length documentation caveats #3152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Removed the caveats on not being allowed to use variables/immutables as length arguments for
slice()
I think these applied in a previous version of Vyper, but as of at least v0.3.7 the restriction doesn't seem to apply anymore
How to verify it
Tests with variables for length arguments exist already in
tests/parser/functions/test_slice.py
, such astest_basic_slice()
A
test_slice_immutable_length_arg()
was also added to demonstrate that the functionality is availableCommit message
Remove slice() length documentation caveats
Description for the changelog
Remove
slice()
length documentation caveatsCute Animal Picture