Add support for all base types when importing interface from ABI #3154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Importing interfaces from ABI failed with some types such as
uint8
.For instance, importing the following interface:
Will cause an error:
vyper.exceptions.StructureException: Type uint8 not supported by vyper.
How I did it
Changed supported types in ast to abi conversion in
interface.py
from("int128", "uint256", "bool", "address", "bytes32")
to{"address", "bool"} | BYTES_M_TYPES | INTEGER_TYPES
.How to verify it
Importing the interface from the snippet above.
Commit message
Add support for all base types when importing interface from ABI
Description for the changelog
Cute Animal Picture