-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make send() gas stipend configurable #3158
feat: make send() gas stipend configurable #3158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a test
Codecov Report
@@ Coverage Diff @@
## master #3158 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 85 85
Lines 10758 10760 +2
Branches 2286 2286
=======================================
+ Hits 9523 9525 +2
Misses 787 787
Partials 448 448
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thanks! working on test |
impl looks good. please add docs and tests, fix lint and should be good to merge |
Also updated type of 'gas' in KwargSettings() to reflect Type refactor
db34883
to
ec77d49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, just some minor questions
took out unnecessary test |
lgtm, thanks |
What I did
added gas= kwarg to send() to handle #3060
How I did it
added gas= kwarg to built-in send() function and logic to handle the output when gas is passed as a kwarg
How to verify it
Commit message
make send() gas stipend configurable
Description for the changelog
Cute Animal Picture