-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: complex arguments to builtin functions #3167
Conversation
ceil
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3167 +/- ##
==========================================
+ Coverage 89.05% 89.32% +0.27%
==========================================
Files 86 84 -2
Lines 10792 10777 -15
Branches 2449 2459 +10
==========================================
+ Hits 9611 9627 +16
+ Misses 781 754 -27
+ Partials 400 396 -4
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codegen looks good, but i don't think the test cases are testing the case properly. i think a better test would have (non-idempotent) side effects in the called contract so you can check if the side effects are getting invoked once or multiple times.
also, since the test functionality is repeated (here, and also in other places but we don't need to worry about the other places just now), it could be good to have some scaffolding / utilities which make this easier. i'm thinking like, a common contract which is intended to be called for its side effects, and a utility function which checks that the side effect was invoked exactly one time. |
I have added two fixtures |
the fixtures look a bit weird to me, but i'm not sure there is a much cleaner way to do it |
I am not sure why this call to
I will set the argument for only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleaned up the side effects checker API a little in 5323481
What I did
Fix #3164, and also
ecadd
andecmul
.How I did it
Cache the argument.
How to verify it
See tests.
Commit message
Description for the changelog
Fix codegen for function calls as argument in builtin functions
Cute Animal Picture