docs: fix docs of blockhash to reflect revert behaviour #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
- Coverage 88.48% 88.40% -0.08%
==========================================
Files 85 85
Lines 10756 10756
Branches 2286 2286
==========================================
- Hits 9517 9509 -8
- Misses 789 797 +8
Partials 450 450
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Improved documentation of the blockhash built-in to describe its behaviour.
The blockhash function clamps its input and will thus revert if it is out of bounds. It will not return
EMPTY_BYTES32as was previously described.How I did it
Updated the docs
How to verify it
See blockhash code
Commit message
docs: fix docs of blockhash to reflect revert behaviour
Description for the changelog
Update the documentation of the blockhash to accurately reflect its revert behaviour.
Cute Animal Picture