fixed the compiler panicking when a break
is outside of a loop
#3177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed #3176
How I did it
Removed
vy.ast.Break
fromignored_types
inFunctionNodeVisitor
and created a functionVisit_Break
that behave similarly tovisit_Continue
to check that thebreak
statement is enclosed in a loop.How to verify it
Compiling the following contract will now output
vyper.exceptions.StructureException: `break` must be enclosed in a `for` loop
instead of the compiler panicking.Commit message
fix: improve error message for
break
statement outside of a loopDescription for the changelog
Improve error message for
break
statement outside of a loopCute Animal Picture