fix: missing pc map for empty functions #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the IR generated inside of a function (that is not generated in stmt.py or expr.py) was not annotated with the source pos. this annotates the root node of the function with the source pos as the fallback.
Codecov Report
@@ Coverage Diff @@
## master #3202 +/- ##
=======================================
Coverage 88.43% 88.43%
=======================================
Files 88 88
Lines 11046 11046
Branches 2338 2338
=======================================
Hits 9769 9769
Misses 822 822
Partials 455 455
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
charles-cooper
changed the title
fubuloubu
approved these changes
Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the IR generated inside of a function (that is not generated in stmt.py or expr.py) was not annotated with the source pos. this annotates the root node of the function with the source pos as the fallback.
What I did
fix #3200
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture