Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index id param in URI event of ERC1155ownable #3203

Merged
merged 1 commit into from
Dec 19, 2022
Merged

index id param in URI event of ERC1155ownable #3203

merged 1 commit into from
Dec 19, 2022

Conversation

pcaversaccio
Copy link
Collaborator

What I did

The ERC-1155 event URI is defined like that:

event URI(string _value, uint256 indexed _id);

Fix the missing index in the example contract ERC1155ownable.

How to verify it

Check here: https://eips.ethereum.org/EIPS/eip-1155.

Commit message

index id param in URI event of ERC1155ownable

Description for the changelog

Index id param in URI event of example contract ERC1155ownable.

Cute Animal Picture

image

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine if tests pass

@fubuloubu fubuloubu enabled auto-merge (squash) December 19, 2022 17:02
@codecov-commenter
Copy link

Codecov Report

Merging #3203 (6888d95) into master (f992492) will decrease coverage by 21.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3203       +/-   ##
===========================================
- Coverage   88.43%   67.23%   -21.21%     
===========================================
  Files          88       88               
  Lines       11046    11042        -4     
  Branches     2338     2271       -67     
===========================================
- Hits         9769     7424     -2345     
- Misses        822     2961     +2139     
- Partials      455      657      +202     
Impacted Files Coverage Δ
vyper/builtins/_utils.py 0.00% <0.00%> (-100.00%) ⬇️
vyper/ir/s_expressions.py 5.88% <0.00%> (-88.24%) ⬇️
vyper/ast/natspec.py 12.34% <0.00%> (-86.42%) ⬇️
vyper/cli/utils.py 16.66% <0.00%> (-71.43%) ⬇️
vyper/compiler/utils.py 30.00% <0.00%> (-70.00%) ⬇️
vyper/cli/vyper_json.py 9.40% <0.00%> (-69.69%) ⬇️
vyper/semantics/types/utils.py 30.30% <0.00%> (-65.16%) ⬇️
vyper/compiler/output.py 27.60% <0.00%> (-61.46%) ⬇️
vyper/semantics/analysis/data_positions.py 36.84% <0.00%> (-54.74%) ⬇️
vyper/builtins/_convert.py 39.42% <0.00%> (-51.62%) ⬇️
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fubuloubu fubuloubu merged commit 8141cdf into vyperlang:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants