Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block bitwise ops on decimals #3219

Merged

Conversation

charles-cooper
Copy link
Member

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test?

@charles-cooper
Copy link
Member Author

test?

added - e063307

@charles-cooper charles-cooper enabled auto-merge (squash) January 6, 2023 16:56
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #3219 (e063307) into master (3abe588) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3219      +/-   ##
==========================================
+ Coverage   88.71%   88.93%   +0.21%     
==========================================
  Files          85       84       -1     
  Lines       10740    10581     -159     
  Branches     2257     2206      -51     
==========================================
- Hits         9528     9410     -118     
+ Misses        781      760      -21     
+ Partials      431      411      -20     
Impacted Files Coverage Δ
vyper/semantics/types/primitives.py 92.50% <100.00%> (ø)
vyper/ast/signatures/function_signature.py 88.28% <0.00%> (-1.81%) ⬇️
vyper/compiler/phases.py 90.90% <0.00%> (-0.17%) ⬇️
vyper/ast/nodes.py 93.77% <0.00%> (-0.16%) ⬇️
vyper/codegen/context.py 91.91% <0.00%> (-0.06%) ⬇️
vyper/ast/signatures/interface.py
vyper/codegen/expr.py 88.19% <0.00%> (+0.41%) ⬆️
vyper/codegen/module.py 97.70% <0.00%> (+3.30%) ⬆️
vyper/codegen/global_context.py 100.00% <0.00%> (+24.78%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper merged commit 77f1c31 into vyperlang:master Jan 6, 2023
@charles-cooper charles-cooper deleted the fix/block_bitwise_decimal branch January 8, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants