Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfile to reduce image size #3224

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

tdurieux
Copy link
Contributor

Hi there,

What I did

I've made a small improvement to the Dockerfile that I think could help optimize the image size.

How I did it

  • I added the --no-cache-dir to the pip command to disable the package cache.

Impact on the image size:

  • Image size before repair: 453.77 MB
  • Image size after repair: 429.87 MB
  • Difference: 23.9 MB (5.27%)

How to verify it

  • Apply the patch and verify that the image still build

Commit message

chore: remove pip cache from the Docker image

Description for the changelog

Remove the pip cache from the Docker image to reduce its size by 23.9 MB

I hope that you will find these changes useful to you. Let me know if you have any questions or concerns.

@charles-cooper charles-cooper enabled auto-merge (squash) January 11, 2023 15:09
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #3224 (cace604) into master (ae7d6d2) will increase coverage by 16.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3224       +/-   ##
===========================================
+ Coverage   72.73%   88.93%   +16.20%     
===========================================
  Files          84       84               
  Lines       10580    10584        +4     
  Branches     2139     2207       +68     
===========================================
+ Hits         7695     9413     +1718     
+ Misses       2271      760     -1511     
+ Partials      614      411      -203     
Impacted Files Coverage Δ
vyper/codegen/ir_node.py 91.03% <0.00%> (+1.72%) ⬆️
vyper/abi_types.py 83.33% <0.00%> (+1.78%) ⬆️
vyper/ast/signatures/function_signature.py 88.28% <0.00%> (+1.80%) ⬆️
vyper/codegen/arithmetic.py 84.71% <0.00%> (+2.02%) ⬆️
vyper/codegen/context.py 91.91% <0.00%> (+2.94%) ⬆️
vyper/semantics/types/primitives.py 92.50% <0.00%> (+3.50%) ⬆️
vyper/builtins/_signatures.py 97.64% <0.00%> (+3.52%) ⬆️
vyper/codegen/self_call.py 95.65% <0.00%> (+4.34%) ⬆️
vyper/codegen/module.py 97.70% <0.00%> (+5.74%) ⬆️
vyper/codegen/external_call.py 97.29% <0.00%> (+6.30%) ⬆️
... and 44 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper merged commit 6176037 into vyperlang:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants