fix: enforce that loop's iterators are valid names #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trocher
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3242 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 84 84
Lines 10588 10590 +2
Branches 2208 2209 +1
=======================================
+ Hits 9417 9419 +2
Misses 760 760
Partials 411 411
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
charles-cooper
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed #3241
How I did it
Added a check to raise an exception if the iterator of a loop is not a
Name.How to verify it
See test
Commit message
Description for the changelog
Enforce that loop's iterators are valid names
Cute Animal Picture