-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deleted unnecessary arguments on ERC1155 #3263
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3263 +/- ##
==========================================
- Coverage 88.87% 88.44% -0.44%
==========================================
Files 84 84
Lines 10593 10589 -4
Branches 2212 2144 -68
==========================================
- Hits 9415 9365 -50
- Misses 769 811 +42
- Partials 409 413 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
included comments from @fubuloubu regarding ERC1155 standard arguments |
still see the files |
If you delete those three empty files we can merge |
deleted empty files @fubuloubu I'm ready to merge 👉👈 |
What I did
deleted unnecessary arguments that were not being used on ERC1155.vy also modified test_erc1155.py arguments for testing
How I did it
deleted them from the functions
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture