Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted unnecessary arguments on ERC1155 #3263

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Conversation

victor-ego
Copy link
Contributor

What I did

deleted unnecessary arguments that were not being used on ERC1155.vy also modified test_erc1155.py arguments for testing

How I did it

deleted them from the functions

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

examples/tokens/ERC1155ownable.vy Outdated Show resolved Hide resolved
examples/tokens/ERC1155ownable.vy Outdated Show resolved Hide resolved
tests/.gitignore Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Merging #3263 (5869e4c) into master (b5eb5f7) will decrease coverage by 0.44%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3263      +/-   ##
==========================================
- Coverage   88.87%   88.44%   -0.44%     
==========================================
  Files          84       84              
  Lines       10593    10589       -4     
  Branches     2212     2144      -68     
==========================================
- Hits         9415     9365      -50     
- Misses        769      811      +42     
- Partials      409      413       +4     
Impacted Files Coverage Δ
vyper/codegen/arithmetic.py 71.15% <0.00%> (-13.56%) ⬇️
vyper/ir/s_expressions.py 91.17% <0.00%> (-2.95%) ⬇️
vyper/semantics/types/primitives.py 90.54% <0.00%> (-2.00%) ⬇️
vyper/builtins/functions.py 88.96% <0.00%> (-1.48%) ⬇️
vyper/ir/optimizer.py 97.56% <0.00%> (-0.31%) ⬇️
vyper/ast/nodes.py 93.63% <0.00%> (-0.16%) ⬇️
vyper/codegen/abi_encoder.py 88.78% <0.00%> (-0.11%) ⬇️
vyper/semantics/analysis/module.py 86.15% <0.00%> (-0.08%) ⬇️
vyper/codegen/core.py 86.67% <0.00%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@victor-ego victor-ego closed this Jan 30, 2023
@victor-ego
Copy link
Contributor Author

included comments from @fubuloubu regarding ERC1155 standard arguments bytes: bytes32 and unnecessary files uploaded on test folder

@victor-ego victor-ego reopened this Jan 30, 2023
@fubuloubu
Copy link
Member

included comments from @fubuloubu regarding ERC1155 standard arguments bytes: bytes32 and unnecessary files uploaded on test folder

still see the files

@fubuloubu
Copy link
Member

If you delete those three empty files we can merge

@victor-ego victor-ego closed this Jan 31, 2023
@victor-ego
Copy link
Contributor Author

deleted empty files @fubuloubu I'm ready to merge 👉👈

@victor-ego victor-ego reopened this Jan 31, 2023
@fubuloubu fubuloubu enabled auto-merge (squash) January 31, 2023 15:29
@fubuloubu fubuloubu merged commit f3c8cb9 into vyperlang:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants