Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: length of empty byte arrays and dynamic arrays #3276

Merged
merged 7 commits into from
Feb 17, 2023

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Feb 14, 2023

What I did

Fix #3275.

Also adds DynArray to len() in docs for builtins.

How I did it

Add ~empty case.

How to verify it

See tests

Commit message

fix: length of empty byte arrays and dynamic arrays

Description for the changelog

Fix length of empty byte arrays and dynamic arrays

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #3276 (25afda3) into master (d76c6ed) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #3276   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files          84       84           
  Lines       10599    10599           
  Branches     2214     2214           
=======================================
  Hits         9419     9419           
  Misses        770      770           
  Partials      410      410           
Impacted Files Coverage Δ
vyper/codegen/core.py 86.74% <100.00%> (+0.04%) ⬆️
vyper/builtins/_utils.py 100.00% <0.00%> (ø)
vyper/builtins/functions.py 90.43% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper merged commit 91a810b into vyperlang:master Feb 17, 2023
@tserg tserg deleted the fix/zero_length branch February 18, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompilerPanic when using len and empty together
4 participants