Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve exceptions for implements syntax #3304

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Feb 28, 2023

What I did

Fix #3297, fix #3298.

How I did it

For 3297, change the exception from UnexpectedNodeType to StructureException.
For 3298, as suggested in issue.

How to verify it

See tests

Commit message

chore: improve exceptions for `implements` syntax

Description for the changelog

Improve exceptions for implements syntax

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #3304 (b7d7d88) into master (dd4d0cc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3304      +/-   ##
==========================================
+ Coverage   88.87%   88.89%   +0.01%     
==========================================
  Files          84       84              
  Lines       10594    10595       +1     
  Branches     2211     2212       +1     
==========================================
+ Hits         9415     9418       +3     
+ Misses        770      769       -1     
+ Partials      409      408       -1     
Impacted Files Coverage Δ
vyper/ast/nodes.py 94.10% <100.00%> (+0.31%) ⬆️
vyper/semantics/analysis/module.py 86.29% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fubuloubu fubuloubu merged commit 5dbdd03 into vyperlang:master Feb 28, 2023
@tserg tserg deleted the fix/implements_syntax branch February 28, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants