-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove builtin constants #3350
feat: remove builtin constants #3350
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #3350 +/- ##
==========================================
+ Coverage 88.66% 89.01% +0.34%
==========================================
Files 86 86
Lines 11467 11440 -27
Branches 2607 2605 -2
==========================================
+ Hits 10167 10183 +16
+ Misses 873 835 -38
+ Partials 427 422 -5
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
i'm pretty ok with merging this even for the 0.3.x series tbh. the old constants have been emitting warnings for nearly a year. @fubuloubu thoughts? |
Sure, I think that seems realtively low-impact, but definitely worth broadcasting the breaking change |
…/remove_builtin_constants
…/remove_builtin_constants
nice cleanup! |
What I did
Builtin constants like
MAX_INT128
,MIN_INT128
,MIN_DECIMAL
,MAX_DECIMAL
andMAX_UINT256
have been deprecated since v0.3.4 with the introduction of themin_value
andmax_value
builtins, and further back forZERO_ADDRESS
andEMPTY_BYTES32
with theempty
builtin.This PR removes them from the language entirely, and will be a breaking change.
How I did it
Delete code.
How to verify it
See tests.
Commit message
Description for the changelog
Remove builtin constants.
Cute Animal Picture