Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deploy to ghcr on push #3435

Merged
merged 17 commits into from
May 19, 2023
Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented May 19, 2023

What I did

publish and tag docker images continuously to ghcr.io. i wanted to add custom tagging (so we can retain every commit) in docker hub, but i didn't really like the fact that for docker hub, in order to have custom tags, you need to set up a regular user and log in via that user. the authentication is much cleaner in github actions for ghcr.

(note docker hub pulls are still staying the same, this is just an alternative form of retention going forward).

can preview test builds here: https://github.com/charles-cooper/vyper/pkgs/container/vyper

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper marked this pull request as ready for review May 19, 2023 15:39
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #3435 (348c09e) into master (9037270) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3435      +/-   ##
==========================================
- Coverage   89.32%   89.13%   -0.19%     
==========================================
  Files          84       84              
  Lines       10789    10789              
  Branches     2461     2461              
==========================================
- Hits         9637     9617      -20     
- Misses        755      773      +18     
- Partials      397      399       +2     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper changed the title add workflow to deploy docker on push ci: deploy to ghcr on push May 19, 2023
@charles-cooper charles-cooper requested a review from fubuloubu May 19, 2023 18:26
publish and tag docker images continuously to ghcr.io. adds custom
tagging so we can retain every commit. it's technically possible to do
this on docker hub, but in order to have custom tags, you need to set up
a regular user and log in/push via that user. the authentication is much
cleaner in github actions for ghcr.

(note docker hub pulls for releases are still staying the same, this is
just an alternative form of retention going forward).
@charles-cooper charles-cooper enabled auto-merge (squash) May 19, 2023 19:50
@charles-cooper charles-cooper merged commit 870ad49 into vyperlang:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants