fix: initcode codesize regression #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit fixes a regression in c202c4e. the commit notes state that we rely on the dead code eliminator to prune unused internal functions in the initcode, and said commit tests the dead code eliminator, but some real world contracts in fact experience code blowup.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3450 +/- ##
=======================================
Coverage 89.30% 89.30%
=======================================
Files 84 84
Lines 10787 10794 +7
Branches 2460 2462 +2
=======================================
+ Hits 9633 9640 +7
Misses 756 756
Partials 398 398
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
charles-cooper
force-pushed
the
fix/initcode_blowup
branch
from
c6f5df4
to
de36749
Compare
fubuloubu
approved these changes
May 23, 2023
the new optimizer rules happily optimize out the custom blueprint code for test_bad_code_offset, so manually deploy unoptimized bytecode for this case
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| while i < len(assembly) - 2: | ||
| instr = assembly[i] | ||
| if isinstance(instr, list): | ||
| instr = assembly[i][-1] |
Check warning
Code scanning / CodeQL
Variable defined multiple times
charles-cooper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture