Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build for old ubuntus #3453

Merged

Conversation

charles-cooper
Copy link
Member

python3.11 uses a new libc which is not compatible with ubuntu 20.04.

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

python3.11 uses a new libc which is not compatible with ubuntu 20.04.
@charles-cooper charles-cooper marked this pull request as ready for review May 23, 2023 21:07
@charles-cooper charles-cooper enabled auto-merge (squash) May 23, 2023 21:11
@charles-cooper charles-cooper changed the title build for old ubuntus chore: build for old ubuntus May 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3453 (90facbc) into master (036f153) will decrease coverage by 18.97%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master    #3453       +/-   ##
===========================================
- Coverage   89.30%   70.33%   -18.97%     
===========================================
  Files          84       84               
  Lines       10787    10787               
  Branches     2460     2460               
===========================================
- Hits         9633     7587     -2046     
- Misses        756     2582     +1826     
- Partials      398      618      +220     

see 57 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper merged commit 71c8e55 into vyperlang:master May 23, 2023
@charles-cooper charles-cooper deleted the chore/build-old-ubuntu branch May 23, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants