Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error message for nonpayable check #3466

Merged

Conversation

charles-cooper
Copy link
Member

What I did

as title. per @antazoey

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper enabled auto-merge (squash) May 26, 2023 15:08
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Merging #3466 (5caf049) into master (070b0cf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3466   +/-   ##
=======================================
  Coverage   89.30%   89.31%           
=======================================
  Files          84       84           
  Lines       10794    10796    +2     
  Branches     2462     2462           
=======================================
+ Hits         9640     9642    +2     
  Misses        756      756           
  Partials      398      398           
Impacted Files Coverage Δ
.../codegen/function_definitions/external_function.py 100.00% <100.00%> (ø)
vyper/codegen/module.py 97.64% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper merged commit 64733b9 into vyperlang:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants