chore: remove vyper signature from runtime #3471
Conversation
it's going at the end of initcode instead, which is cheaper but still possible to pick up the vyper version by looking at the create tx.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3471 +/- ##
=======================================
Coverage 89.30% 89.30%
=======================================
Files 84 84
Lines 10792 10793 +1
Branches 2461 2461
=======================================
+ Hits 9638 9639 +1
Misses 756 756
Partials 398 398
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@fubuloubu what exactly do you want to see here? the issue i am anticipating is that the contract will not verify anyway because the bytecode will not match 0.3.9 (or any other released version of vyper) |
Doesn't need to be verified, just make sure that regular and blueprint deployments work on Sepolia or something |
using titanoboa, i was able to deploy test contracts with the latest commit on this PR (4394ba4) to sepolia: you can check that the runtime contracts don't contain the vyper signature: and the blueprint contract does: all three contain the signature in the creation traces: also note that a recent dashboard created to check vyper deployments in fact already uses the creation trace as opposed to the runtime signature (presumably because immutables are appended after signature in the bytecode): https://dune.com/queries/2555852/4221288 |
it's going at the end of initcode instead, which is cheaper but still possible to pick up the vyper version by looking at the create tx.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture