fix: pc maps for function selectors #3487
Conversation
the existing pc annotator was annotating functions too early - when we do the check in the selector table rather than when the function is actually entered into. this moves the pc annotation to a few instructions later in the codegen so that tracers will not be confused as to where the function actually starts.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vyper/codegen/ir_node.py
Outdated
| #if self.source_pos: | ||
| # o += f"/* POS {self.source_pos} */ " |
Check notice
Code scanning / CodeQL
Commented-out code
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3487 +/- ##
===========================================
- Coverage 89.18% 72.83% -16.36%
===========================================
Files 84 84
Lines 10970 10776 -194
Branches 2506 2456 -50
===========================================
- Hits 9784 7849 -1935
- Misses 774 2313 +1539
- Partials 412 614 +202
... and 54 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
this is superseded by #3496 because the method id checks were moved out of external function body code generation into |
the existing pc annotator was annotating functions too early - when we do the check in the selector table rather than when the function is actually entered into. this moves the pc annotation to a few instructions later in the codegen so that tracers will not be confused as to where the function actually starts.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture