fix: typechecking of folded builtins

[trocher]

What I did

Fix #3486

How I did it

The eval functions of the builtins having integer arguments now expect Int instead of Num.

How to verify it

The following contract now fails to compile with InvalidType instead of a CompilerPanic.

@external
def foo():
    ds:uint256 = uint256_addmod(1.1,2.2,2)

Commit message

fix: typechecking of folded builtins.

Description for the changelog

Prevent decimals from being passed as parameters to builtins expecting integers.

Cute Animal Picture

[codecov-commenter]

Codecov Report

Merging #3490 (efde32e) into master (c90ab2f) will increase coverage by 0.02%.
The diff coverage is 14.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3490      +/-   ##
==========================================
+ Coverage   89.35%   89.37%   +0.02%     
==========================================
  Files          84       84              
  Lines       10777    10780       +3     
  Branches     2456     2457       +1     
==========================================
+ Hits         9630     9635       +5     
+ Misses        751      749       -2     
  Partials      396      396              

Impacted Files	Coverage Δ
vyper/builtins/functions.py	90.51% <14.28%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[charles-cooper]

looks good! approved, but i think it would be good to add some unit tests which validate that the correct type of exception is being thrown too before merging.

[trocher]

looks good! approved, but i think it would be good to add some unit tests which validate that the correct type of exception is being thrown too before merging.

Only added tests for uint256_addmod and uint256_mulmod as the others concerned builtins are deprecated, should I also do some for them?

[charles-cooper]

Only added tests for uint256_addmod and uint256_mulmod as the others concerned builtins are deprecated, should I also do some for them?

no, it looks good. thanks!