Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with finding installed packages in editable mode #3510

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

antazoey
Copy link
Contributor

What I did

fixes: #3509

How I did it

fix how packages are found
exclude kwarg was not working as expected i dont think, that seems to be for file globs within the found packages

How to verify it

uninstall
reininstall in editable mode
go somewhere else (cd)

python -c "import tests; print(tests.__path__)"

^ should not output anything about vyper

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@antazoey antazoey changed the title refactor: src dir fix: issue with finding installed packages in editable mode Jul 17, 2023
@charles-cooper
Copy link
Member

hmm -- is there any way to accomplish this without requiring a change to the directory structure?

@antazoey
Copy link
Contributor Author

hmm -- is there any way to accomplish this without requiring a change to the directory structure?

i have tried but to no avail but i was hoping you would tell me a better way

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #3510 (150a06e) into master (9e3b9a2) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3510   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files          84       84           
  Lines       10953    10953           
  Branches     2503     2503           
=======================================
  Hits         9766     9766           
  Misses        775      775           
  Partials      412      412           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper
Copy link
Member

charles-cooper commented Jul 17, 2023

i mean -- what if we just used the 'include' directive? so find_packages(include="vyper"). or maybe even just packages=["vyper"]

@antazoey
Copy link
Contributor Author

antazoey commented Jul 17, 2023

i mean -- what if we just used the 'include' directive? so find_packages(include="vyper"). or maybe even just packages=["vyper"]

does this work for you?
like did it fix the bug?

@antazoey
Copy link
Contributor Author

i mean -- what if we just used the 'include' directive? so find_packages(include="vyper"). or maybe even just packages=["vyper"]

YES, you are right. I changed it. Sorry about all the running around!

@charles-cooper
Copy link
Member

thanks!

@charles-cooper charles-cooper enabled auto-merge (squash) July 19, 2023 15:46
@charles-cooper charles-cooper merged commit cfba517 into vyperlang:master Jul 19, 2023
75 of 76 checks passed
@antazoey antazoey deleted the refactor/src-dir branch July 19, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests module is importable outside of Vyper package
3 participants