-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue with finding installed packages in editable mode #3510
Conversation
098d49e
to
ee70426
Compare
hmm -- is there any way to accomplish this without requiring a change to the directory structure? |
i have tried but to no avail but i was hoping you would tell me a better way |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3510 +/- ##
=======================================
Coverage 89.16% 89.16%
=======================================
Files 84 84
Lines 10953 10953
Branches 2503 2503
=======================================
Hits 9766 9766
Misses 775 775
Partials 412 412 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
i mean -- what if we just used the |
does this work for you? |
ee70426
to
81e55a5
Compare
YES, you are right. I changed it. Sorry about all the running around! |
thanks! |
What I did
fixes: #3509
How I did it
fix how packages are found
exclude kwarg was not working as expected i dont think, that seems to be for file globs within the found packages
How to verify it
uninstall
reininstall in editable mode
go somewhere else (cd)
python -c "import tests; print(tests.__path__)"
^ should not output anything about vyper
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture