Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax pragma parsing #3511

Merged

Conversation

charles-cooper
Copy link
Member

allow # pragma ... in addition to #pragma ...

also fix a small bug in version parsing (it only affected the error message formatting, not the parsed version)

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

allow `# pragma ...` in addition to `#pragma ...`

also fix a small bug in version parsing (it only affected the error
message formatting, not the parsed version)
@charles-cooper charles-cooper requested a review from fubuloubu July 19, 2023 05:36
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #3511 (c54299d) into master (9e3b9a2) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3511   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files          84       84           
  Lines       10953    10953           
  Branches     2503     2503           
=======================================
  Hits         9766     9766           
  Misses        775      775           
  Partials      412      412           
Impacted Files Coverage Δ
vyper/ast/pre_parser.py 84.78% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper merged commit 6bd81de into vyperlang:master Jul 19, 2023
@charles-cooper charles-cooper deleted the chore/relax_pragma_parsing branch July 19, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants