Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on security advisory for ecrecover in docs #3539

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Add note on security advisory for ecrecover in docs #3539

merged 2 commits into from
Aug 7, 2023

Conversation

pcaversaccio
Copy link
Collaborator

@pcaversaccio pcaversaccio commented Jul 26, 2023

What I did

I added a note on the recent security advisory for ecrecover in the docs. I also replaced 0 with empty(address) in case of error.

How I did it

Added a note section in the ecrecover docs.

How to verify it

Reference: GHSA-f5x6-7qgp-jhf3

Commit message

Add note on security advisory for `ecrecover` in docs

Description for the changelog

Add note on security advisory for ecrecover in docs.

Cute Animal Picture

image

pcaversaccio and others added 2 commits July 26, 2023 17:00
Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
@pcaversaccio
Copy link
Collaborator Author

LGTM
image

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #3539 (336168c) into master (3c3285c) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3539      +/-   ##
==========================================
- Coverage   89.14%   89.11%   -0.04%     
==========================================
  Files          85       85              
  Lines       11362    11362              
  Branches     2584     2584              
==========================================
- Hits        10129    10125       -4     
- Misses        812      816       +4     
  Partials      421      421              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wish there was a way to update older documentation

@charles-cooper charles-cooper merged commit 728a276 into vyperlang:master Aug 7, 2023
@pcaversaccio pcaversaccio deleted the ecrecover branch August 7, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants