Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guard against kwargs for range expressions with two arguments #3551

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Aug 5, 2023

What I did

Fix #3550

How I did it

Check kwargs for range expressions with two arguments.

How to verify it

See tests.

Commit message

fix: guard against kwargs for `range` expressions with two arguments

Keyword arguments are not supported for `range(N, M)` and
`range(x, x + N)` expressions.

Description for the changelog

Guard against kwargs for range expressions with two arguments

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2023

Codecov Report

Merging #3551 (2851a0c) into master (cfda16c) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3551   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files          85       85           
  Lines       11362    11365    +3     
  Branches     2584     2585    +1     
=======================================
+ Hits        10125    10128    +3     
  Misses        816      816           
  Partials      421      421           
Files Changed Coverage Δ
vyper/semantics/analysis/local.py 91.68% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

and slight refactor -- rename node.iter to range_
@charles-cooper charles-cooper enabled auto-merge (squash) August 7, 2023 15:51
@charles-cooper charles-cooper merged commit 43c8d85 into vyperlang:master Aug 7, 2023
@tserg tserg deleted the fix/range_kwarg branch August 7, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of kwargs not prevented for range(N,M) or range(x,x+N)
3 participants