-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implements check for indexed event arguments #3570
fix: implements check for indexed event arguments #3570
Conversation
prior to this commit, implementing an interface with wrong indexed arguments for an event would pass the implements check. this commit fixes the behavior. chainsec june 2023 review 5.12
c991f76
to
3f5e703
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3570 +/- ##
==========================================
- Coverage 89.13% 88.77% -0.36%
==========================================
Files 85 85
Lines 11365 11378 +13
Branches 2585 2586 +1
==========================================
- Hits 10130 10101 -29
- Misses 813 852 +39
- Partials 422 425 +3
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a test
prior to this commit, implementing an interface with wrong indexed arguments for an event would pass the implements check. this commit fixes the behavior.
chainsec june 2023 review 5.12
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture