-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: order of evaluation for some builtins #3583
fix: order of evaluation for some builtins #3583
Conversation
ecadd, ecmul, addmod, mulmod in the case that the arguments have side effects, they could be evaluated out of order chainsec june 2023 review 5.1
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3583 +/- ##
==========================================
- Coverage 89.05% 87.50% -1.56%
==========================================
Files 85 85
Lines 11378 11390 +12
Branches 2586 2586
==========================================
- Hits 10133 9967 -166
- Misses 821 990 +169
- Partials 424 433 +9
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: trocher <43437004+trocher@users.noreply.github.com>
Point for a quick discussion: do you guys see any need to document this (or link to GHSA-4hg4-9mf5-wxxq) in the docs? |
As per offline discussion with @charles-cooper, it would make sense to have a general bug section in the docs; similar to https://docs.soliditylang.org/en/v0.8.21/bugs.html. I will open an issue accordingly. |
ecadd, ecmul, addmod, mulmod
in the case that the arguments have side effects, they could be evaluated out of order
chainsec june 2023 review 5.1
patch for GHSA-4hg4-9mf5-wxxq
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture