Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ecrecover() edge case #3586

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Sep 5, 2023

What I did

fix an edge case that was not coverd by 019a37a

How I did it

How to verify it

Commit message

this commit fixes an edge case in `ecrecover()` that was not covered by
019a37ab98ff5. in the case that one of the arguments to ecrecover writes
to memory location 0, and the signature is invalid, `ecrecover()` could
return the data written by the argument. this commit fixes the issue by
allocating fresh memory for the output buffer (which won't be written to
by evaluating any of the arguments unless the memory allocator is
broken).

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper enabled auto-merge (squash) September 5, 2023 21:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #3586 (3a687b9) into master (2c21eab) will decrease coverage by 0.08%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3586      +/-   ##
==========================================
- Coverage   89.05%   88.98%   -0.08%     
==========================================
  Files          85       85              
  Lines       11378    11390      +12     
  Branches     2586     2586              
==========================================
+ Hits        10133    10135       +2     
- Misses        821      830       +9     
- Partials      424      425       +1     
Files Changed Coverage Δ
vyper/builtins/functions.py 90.55% <100.00%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper merged commit a854929 into vyperlang:master Sep 5, 2023
76 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants