Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing test for memory allocation overflow #3650

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Oct 19, 2023

should have been added in #3639 but the file was not committed

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

should have been added in 68da04b but the file was not committed
@codecov-commenter
Copy link

Codecov Report

Merging #3650 (06c4380) into master (5482bbc) will increase coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #3650      +/-   ##
==========================================
+ Coverage   89.08%   89.14%   +0.05%     
==========================================
  Files          86       86              
  Lines       11455    11455              
  Branches     2605     2605              
==========================================
+ Hits        10205    10211       +6     
+ Misses        830      825       -5     
+ Partials      420      419       -1     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper marked this pull request as ready for review October 19, 2023 22:50
@charles-cooper charles-cooper changed the title add missing test fix: add missing test for memory allocation overflow Oct 20, 2023
@charles-cooper charles-cooper merged commit ed0b1e0 into vyperlang:master Oct 20, 2023
82 of 83 checks passed
@charles-cooper charles-cooper deleted the test-missing-malloc-limit branch October 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants