Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warnings at the top of all example token contracts #3676

Merged

Conversation

charles-cooper
Copy link
Member

discourage people from using them in production (which, apparently people were doing)

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

discourage people from using them in production
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dd47e3) 89.61% compared to head (6909a6b) 89.90%.
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3676      +/-   ##
==========================================
+ Coverage   89.61%   89.90%   +0.29%     
==========================================
  Files          80       79       -1     
  Lines       11343    11257      -86     
  Branches     2553     2544       -9     
==========================================
- Hits        10165    10121      -44     
+ Misses        791      747      -44     
- Partials      387      389       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could say "not audited"

@charles-cooper
Copy link
Member Author

Could say "not audited"

i think that might imply they are somehow supposed to be production contracts, we just forgot to audit them 😅. they really are sample contracts, and i think people should use other resources if they want templates they can actually use in production.

@charles-cooper charles-cooper merged commit b334218 into vyperlang:master Nov 23, 2023
84 checks passed
@charles-cooper charles-cooper deleted the docs/example_warnings branch November 23, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants