feat: allow range with two arguments and bound #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vyperlang#3678 Adds test coverage for touched code
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3679 +/- ##
==========================================
+ Coverage 83.92% 83.97% +0.05%
==========================================
Files 92 92
Lines 13065 13044 -21
Branches 2934 2928 -6
==========================================
- Hits 10965 10954 -11
+ Misses 1666 1661 -5
+ Partials 434 429 -5 ☔ View full report in Codecov by Sentry. |
|
tests need to be updated to use the new |
vyper/codegen/stmt.py
Outdated
| else: | ||
| arg1 = self.stmt.iter.args[1] | ||
| rounds = self._get_range_const_value(arg1.right) | ||
| raise InvalidOperation("Invalid number of arguments to range()") |
There was a problem hiding this comment.
this should be a panic really
charles-cooper
added a commit
to charles-cooper/vyper
that referenced
this pull request
Dec 27, 2023
- allow range where both start and end arguments are variables, so long as a bound is supplied - ban range expressions of the form `range(x, x + N)` since the new form is cleaner and supersedes it. - also do a bit of refactoring of the codegen for range --------- Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
DanielSchiavini
added a commit
to DanielSchiavini/vyper-plugin
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3678
What I did
rangewith 2 argumentsHow I did it
How to verify it
Tests are included
Commit message
Allow range(x, y, bound=N)Description for the changelog
Add support for range with start/end runtime arguments as long as a
boundargument is given.Cute Animal Picture