feat: Implement target constrained venom jump instruction #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_instruction methods
adopted a shorted name for frequently used methods
Refactored append instructions into a single append_instruction() method with named arguments for returning or not a variable
Until now log instructions where pass through. Now we have a log instruction in venom that takes the first argument to be the topic count (in shape of doing table jmp etc in the future -essentialy have instructions that require manipulation of operants before emit)
Remove output argument append_instruction() in IRBasicBlock now the method decides by itself if there is an output value
normalization pass
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3687 +/- ##
==========================================
- Coverage 83.98% 83.94% -0.05%
==========================================
Files 92 92
Lines 13046 13056 +10
Branches 2928 2932 +4
==========================================
+ Hits 10957 10960 +3
- Misses 1657 1663 +6
- Partials 432 433 +1 ☔ View full report in Codecov by Sentry. |
harkal
force-pushed
the
feature/jump_table
branch
from
8b06837
to
e9d7030
Compare
harkal
changed the title
charles-cooper
requested changes
Dec 13, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- remove experimental codegen flag passing - rewrite a bit of code in module.py - add the code generator in old IR
charles-cooper
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR augments the venom jump instruction to require the possible jump targets as arguments when it is jumping to a dynamic location. This removes all the workarounds that we had to implement in the normalization pass and the cfg calculations.
How I did it
I passed the jump table data thought the ir_node to the translator. Then the translator can emit the proper venom instruction.
How to verify it
Commit message
Description for the changelog
Cute Animal Picture