Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type annotation of helper function #3702

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

harkal
Copy link
Collaborator

@harkal harkal commented Dec 20, 2023

What I did

Fixed the signature of _append_return_for_stack_operand() to take the context not the basic block

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@harkal harkal self-assigned this Dec 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b0ea5b6) 83.98% compared to head (4e43d5c) 83.69%.

Files Patch % Lines
vyper/venom/ir_node_to_venom.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3702      +/-   ##
==========================================
- Coverage   83.98%   83.69%   -0.30%     
==========================================
  Files          92       92              
  Lines       13046    13047       +1     
  Branches     2928     2928              
==========================================
- Hits        10957    10920      -37     
- Misses       1657     1693      +36     
- Partials      432      434       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title fix: small refactor left out fix: type annotation of helper function Dec 20, 2023
@charles-cooper charles-cooper merged commit 5a67b68 into vyperlang:master Dec 20, 2023
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants