feat: remove deploy instruction from venom
#3703
Conversation
add_instruction methods
adopted a shorted name for frequently used methods
Refactored append instructions into a single append_instruction() method with named arguments for returning or not a variable
Until now log instructions where pass through. Now we have a log instruction in venom that takes the first argument to be the topic count (in shape of doing table jmp etc in the future -essentialy have instructions that require manipulation of operants before emit)
Remove output argument append_instruction() in IRBasicBlock now the method decides by itself if there is an output value
normalization pass
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3703 +/- ##
==========================================
+ Coverage 83.99% 84.12% +0.13%
==========================================
Files 92 92
Lines 13056 13034 -22
Branches 2932 2919 -13
==========================================
- Hits 10966 10965 -1
+ Misses 1658 1649 -9
+ Partials 432 420 -12 ☔ View full report in Codecov by Sentry. |
vyper/venom/__init__.py
Outdated
| @@ -19,17 +19,14 @@ | |||
|
|
|||
|
|
|||
| def generate_assembly_experimental( | |||
| ctx: IRFunction, optimize: Optional[OptimizationLevel] = None | |||
| ctxs: tuple[IRFunction, IRFunction], optimize: Optional[OptimizationLevel] = None | |||
There was a problem hiding this comment.
this should either be a list of IRFunctions or specify by names -- runtime_ir and deploy_ir.
| @@ -75,13 +77,13 @@ | |||
| # with the assembler. My suggestion is to let this be for now, and we can | |||
| # refactor it later when we are finished phasing out the old IR. | |||
| class VenomCompiler: | |||
| ctx: IRFunction | |||
| ctxs: list[IRFunction] | |||
There was a problem hiding this comment.
should these still be named ctxs? maybe functions?
generate_assembly_experimental() is just glue code for the old-new code interface. It's basic purpose is to "untangle" the combinations of ir_runtime and ir_nodes properties that depending on the run parameters can be multiple things (one of them being the (None, IRnode) tuple in the case of doing runtime only code. VenomCompiler() takes just a list of IRFunctions to compile, which is clean. With the last commit I removed the None check inside VenomCompiler for cleaning up the list of Nones in the glue code which is indeed nicer. |
…:harkal/vyper into feature/venom_deploy_instruction_removal
we no longer need special cases because of better handling now for deploy instruction.
charles-cooper
changed the title
deploy instruction from venom
What I did
Venom IR for an easier transition employed a
deployinstruction like the old IR. This was creating friction in the new system as it was implicitly dictating basic block flows, that had to be handled with special cases code.This PR removes the need for the
deployinstruction. The original IR is split into deploy and runtime code as soon as possible, and the two parts are handed to the new backend, which now handles any number of contexts that it links when emitting assembly.How I did it
How to verify it
Commit message
Removes the need for the
deployinstructiondeployinstructionDescription for the changelog
Cute Animal Picture