Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve exception handling in IR generation #3705

Merged

Conversation

charles-cooper
Copy link
Member

QOL improvement -- add annotations where missing to exceptions which happen during code generation

also, moves the tag_exceptions() helper to vyper.exceptions

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

improve unannotated exceptions that happen during IR generation to
include source info.
@charles-cooper charles-cooper enabled auto-merge (squash) December 20, 2023 19:28
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0ea5b6) 83.98% compared to head (5aabc56) 83.97%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3705      +/-   ##
==========================================
- Coverage   83.98%   83.97%   -0.02%     
==========================================
  Files          92       92              
  Lines       13046    13051       +5     
  Branches     2928     2931       +3     
==========================================
+ Hits        10957    10959       +2     
- Misses       1657     1659       +2     
- Partials      432      433       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 9165926 into vyperlang:master Dec 20, 2023
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants