feat: improve panics in IR generation #3708
Conversation
this QOL commit improves on 9165926 by passing through the `__traceback__` field when the exception is modified (instead of using `__cause__` - cf. PEP-3134 regarding the difference) and improves error messages when an IRnode is not returned properly. using `__traceback__` generally results in a better experience because the immediate cause of the exception is displayed when running `vyper -v` instead of needing to scroll up through the exception chain (if the exception chain is reproduced correctly at all in the first place).
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3708 +/- ##
==========================================
+ Coverage 83.97% 84.02% +0.04%
==========================================
Files 92 92
Lines 13044 13045 +1
Branches 2928 2925 -3
==========================================
+ Hits 10954 10961 +7
+ Misses 1661 1658 -3
+ Partials 429 426 -3 ☔ View full report in Codecov by Sentry. |
|
I'm not sure this is the right venue to discuss this (I still drop it here tho), but I thought it would be valuable if we would start adding labels and milestones for each PR going forward:
Like the milestone is usually the next Vyper release number & the label can be e.g. Using such an approach would help a lot to filter for the PRs someone is interested in reading. At least I use this approach for e.g. 🐍 snekmate (see an example here), and people appreciate it. Let me know what you think about it. |
* feat: improve panics in IR generation this QOL commit improves on 9165926 by passing through the `__traceback__` field when the exception is modified (instead of using `__cause__` - cf. PEP-3134 regarding the difference) and improves error messages when an IRnode is not returned properly. using `__traceback__` generally results in a better experience because the immediate cause of the exception is displayed when running `vyper -v` instead of needing to scroll up through the exception chain (if the exception chain is reproduced correctly at all in the first place). --------- Co-authored-by: Harry Kalogirou <harkal@nlogn.eu>
this QOL commit improves on 9165926 by passing through the
__traceback__field when the exception is modified (instead of using__cause__- cf. PEP-3134 regarding the difference) and improves error messages when an IRnode is not returned properly. using__traceback__generally results in a better experience because the immediate cause of the exception is displayed when runningvyper -vinstead of needing to scroll up through the exception chain (if the exception chain is reproduced correctly at all in the first place).What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture