-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow using interface defs from imported modules #3725
fix: allow using interface defs from imported modules #3725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit test could be enriched with another test using a relative import from the parent directory (i.e. from ..dir.ifaces.IFoo import IFoo
) just to ensure that the interface
keyword doesn't break path resolution in some weird way.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3725 +/- ##
==========================================
- Coverage 84.11% 83.86% -0.25%
==========================================
Files 92 92
Lines 13123 13119 -4
Branches 2926 2925 -1
==========================================
- Hits 11038 11002 -36
- Misses 1663 1693 +30
- Partials 422 424 +2 ☔ View full report in Codecov by Sentry. |
in vyper you can't use |
FWIW, I still use that syntax in snekmate: https://github.com/pcaversaccio/snekmate/blob/main/src%2Ftokens%2FERC20.vy#L75 |
yea as discussed offline -- that syntax was probably a bug, and it does not work anymore on master (probably as of #3663 ) anyways. |
Yup, amended in snekmate via pcaversaccio/snekmate#194. |
What I did
fix #2900
How I did it
How to verify it
see new test
Commit message
Description for the changelog
Cute Animal Picture