-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for constants in imported modules #3726
feat: add support for constants in imported modules #3726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we additionally fuzz the input types for the constant values in tests? The unit tests & the overall PR lgtm (besides the open errors) but this would be a great case IMO to parametrise the (allowed) types for a fuzz test.
added a test for arrays -- 251de24 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3726 +/- ##
==========================================
+ Coverage 84.16% 84.21% +0.05%
==========================================
Files 92 92
Lines 13119 13137 +18
Branches 2925 2928 +3
==========================================
+ Hits 11041 11063 +22
+ Misses 1659 1655 -4
Partials 419 419 ☔ View full report in Codecov by Sentry. |
the docs failure is unrelated; fixed here: #3728 |
What I did
allow importing constants from modules
How I did it
add a case to ConstantFolder, and move the constant folder slightly down in the pipeline to after imports have been resolved.
How to verify it
see tests
Commit message
Description for the changelog
Cute Animal Picture